memory: recheck open PRs at PR-open time, not just session start#21
Merged
WillTaylor22 merged 1 commit intoMay 26, 2026
Conversation
Captures the PR #18 vs PR #20 ENG-25 race — same shape as the PR #15 vs #16 ENG-26 race that prompted the original check-open-pr-before-ticket-pickup convention. Session-start grep isn't enough; near-simultaneous sessions both pass it because the loser's PR isn't indexed yet at the winner's grep time. Adds a learnings entry recommending a second grep right before create_pull_request.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
AGENT_REVIEW: APPROVED — doc-only memory entry; format matches existing learnings and the underlying PR #18/#20 race is verifiable against PR history. Checked:
Minor nits (not blocking):
|
WillTaylor22
added a commit
that referenced
this pull request
May 26, 2026
# Conflicts: # .claude/memory/MEMORY.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line memory entry surfaced this tick while deduping PR #18 and PR #20 (both for ENG-25, opened within ~3 min of each other by parallel agent sessions).
Context
The existing
check-open-pr-before-ticket-pickupconvention recommends onelist_pull_requests+ grep beforegit checkout -b. That was added after the PR #15 vs PR #16 ENG-26 race. Today's PR #18 vs PR #20 ENG-25 race is the same shape and shows the original mitigation isn't sufficient: the second session's session-start grep ran before the first session's PR was indexed/visible, so the check passed and the dup got opened anyway.Change
learnings/2026-05-26-recheck-open-prs-at-pr-open.md— one paragraph recommending a secondlist_pull_requestsgrep immediately beforecreate_pull_request, with the loser aborting and posting a Linear comment.MEMORY.mdindex.No code. Index is at 7 lines after this change; cap is 200.
learnings/is at 5 files after this change; cap is 20 — no eviction needed.Note on coexisting changes
PR #20 (ENG-25, still open) modifies the same line of
MEMORY.mdthat this PR does not touch (thegithub-mcp-strips-html-commentshook). This PR adds a new line below it. If PR #20 lands first, this PR rebases cleanly. If this PR lands first, PR #20's edit to the other line is unaffected.session-id: sesn_01Dw6EAgpeu4omuxF1QWYPeC