Fix touch crash after X client disconnect#629
Open
Xnick417x wants to merge 1 commit into
Open
Conversation
A client's XInput2 raw-event selections were never removed on disconnect, so pointer injection kept writing raw motion to its released output stream and hit a null buffer NPE on the main thread. Remove the client's XI2 selections in freeResources, release the output buffer under the stream write lock so an in-flight event write can never race the free, and discard writes on a released stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client's XInput2 raw-event selections were never removed on disconnect, so pointer injection kept writing raw motion to its released output stream and hit a null buffer NPE on the main thread. Remove the client's XI2 selections in freeResources, release the output buffer under the stream write lock so an in-flight event write can never race the free, and discard writes on a released stream.