Cleanup optimize mob spawning#658
Merged
Dreeam-qwq merged 11 commits intover/1.21.11from Mar 9, 2026
Merged
Conversation
- Extract per player mob count update - Move modified NaturalSpawner methods together - Merge `NatureSpawnChunkMap#collectSpawningChunks` into `collectSpawningChunks#build`, since only one call - Code format & complete comments
hayanesuru
approved these changes
Mar 4, 2026
No need to wake up the thread on every time it schedules to execute the task. By only park thread if the queue is empty, it can increase the throughput and also fixed the problem of skipping task executions in original changes in 5237ed9 The behavior remains same as the original try/catch impl, but now it's controlled by `jobs.isEmpty()` instead of the try/catch However still need to check and figure out whether needs to "revert" to base on Pufferfish's original async executor impl. Using `LockSupport#park/unpark` should be lightweight than using `Condition#await/signal`, but shows opposite throughput result in JMH
Co-Authored-By: Creeam <102713261+HaHaWTH@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NatureSpawnChunkMap#collectSpawningChunksintocollectSpawningChunks#build, since only one call