Skip to content

feat: bounded-memory file uploads for huge files (1GB-100GB+) #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickvandijke merged 6 commits into from
Mar 31, 2026
Merged

feat: bounded-memory file uploads for huge files (1GB-100GB+) #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50489ed
feat: bounded-memory file uploads for huge files (1GB-4GB+)
grumbach Mar 31, 2026
ad67c0f
fix: review round 2 — mutex poison handling, imports, merkle gas prio…
grumbach Mar 31, 2026
b2e5ded
fix: review round 2 continued — inline paths, spill dir hardening
grumbach Mar 31, 2026
ad47665
fix: review round 2 — incompressible test data, strict RSS checks
grumbach Mar 31, 2026
6b1ea38
fix: clean up temp file on rename failure in file_download
grumbach Mar 31, 2026
67cebfa
fix: deduplicate chunks in ChunkSpill to prevent double-upload
grumbach Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ant-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,7 @@ path = "tests/merkle_unit.rs"
[[test]]
name = "e2e_merkle"
path = "tests/e2e_merkle.rs"

[[test]]
name = "e2e_huge_file"
path = "tests/e2e_huge_file.rs"
29 changes: 16 additions & 13 deletions ant-core/src/data/client/batch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ use ant_node::core::{MultiAddr, PeerId};
use ant_node::payment::{serialize_single_node_proof, PaymentProof, SingleNodePayment};
use bytes::Bytes;
use evmlib::common::TxHash;
use evmlib::contract::payment_vault::get_market_price;
use evmlib::wallet::PayForQuotesError;
use futures::stream::{self, StreamExt};
use std::collections::{HashMap, HashSet};
use tracing::{debug, info};
Expand Down Expand Up @@ -180,12 +182,11 @@ impl Client {
.map(|(_, _, quote, _)| quote.quoting_metrics.clone())
.collect();

let contract_prices =
evmlib::contract::payment_vault::get_market_price(evm_network, metrics_batch)
.await
.map_err(|e| {
Error::Payment(format!("Failed to get market prices from contract: {e}"))
})?;
let contract_prices = get_market_price(evm_network, metrics_batch)
.await
.map_err(|e| {
Error::Payment(format!("Failed to get market prices from contract: {e}"))
})?;

if contract_prices.len() != quotes_with_peers.len() {
return Err(Error::Payment(format!(
Expand Down Expand Up @@ -237,8 +238,8 @@ impl Client {
let wallet = self.require_wallet()?;

// Flatten all quote payments from all chunks into a single batch.
let mut all_payments =
Vec::with_capacity(prepared.len() * prepared[0].payment.quotes.len());
let total_quotes: usize = prepared.iter().map(|c| c.payment.quotes.len()).sum();
let mut all_payments = Vec::with_capacity(total_quotes);
for chunk in &prepared {
for info in &chunk.payment.quotes {
all_payments.push((info.quote_hash, info.rewards_address, info.amount));
Expand All @@ -251,11 +252,13 @@ impl Client {
all_payments.len()
);

let (tx_hash_map, _gas_info) = wallet.pay_for_quotes(all_payments).await.map_err(
|evmlib::wallet::PayForQuotesError(err, _)| {
Error::Payment(format!("Batch payment failed: {err}"))
},
)?;
let (tx_hash_map, _gas_info) =
wallet
.pay_for_quotes(all_payments)
.await
.map_err(|PayForQuotesError(err, _)| {
Error::Payment(format!("Batch payment failed: {err}"))
})?;

info!(
"Batch payment succeeded: {} transactions",
Expand Down
Loading
Loading