Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Rust dependency on saorsa-core to 0.21.0 and refreshes the lockfile accordingly.
Changes:
- Bump
saorsa-corefrom0.20.0to0.21.0inCargo.toml - Update
Cargo.lockentry (version + checksum) forsaorsa-core
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Updates the direct dependency requirement to saorsa-core = "0.21.0". |
| Cargo.lock | Updates the resolved saorsa-core package version/checksum to match 0.21.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mickvandijke
added a commit
that referenced
this pull request
Apr 1, 2026
Add unit and e2e tests covering the remaining Section 18 scenarios: Unit tests (32 new): - Quorum: #4 fail→abandoned, #16 timeout→inconclusive, #27 single-round dual-evidence, #28 dynamic threshold undersized, #33 batched per-key, #34 partial response unresolved, #42 quorum-derived paid-list auth - Admission: #5 unauthorized peer, #7 out-of-range rejected - Config: #18 invalid config rejected, #26 dynamic paid threshold - Scheduling: #8 dedup safety, #8 replica/paid collapse - Neighbor sync: #35 round-robin cooldown skip, #36 cycle completion, #38 snapshot stability mid-join, #39 unreachable removal + slot fill, #40 cooldown peer removed, #41 cycle termination guarantee, consecutive rounds, cycle preserves sync times - Pruning: #50 hysteresis prevents premature delete, #51 timestamp reset on heal, #52 paid/record timestamps independent, #23 entry removal - Audit: #19/#53 partial failure mixed responsibility, #54 all pass, #55 empty failure discard, #56 repair opportunity filter, response count validation, digest uses full record bytes - Types: #13 bootstrap drain, repair opportunity edge cases, terminal state variants - Bootstrap claims: #46 first-seen recorded, #49 cleared on normal E2e tests (4 new): - #2 fresh offer with empty PoP rejected - #5/#37 neighbor sync request returns response - #11 audit challenge multi-key (present + absent) - Fetch not-found for non-existent key Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mickvandijke
added a commit
that referenced
this pull request
Apr 1, 2026
- #3: Add proper unit test in scheduling.rs exercising full pipeline (PendingVerify → QueuedForFetch → Fetching → Stored); rename mislabeled e2e test to scenario_1_and_24 - #12: Rewrite e2e test to send verification requests to 4 holders and assert quorum-level presence + paid confirmations - #13: Rename mislabeled bootstrap drain test in types.rs; add proper unit test in paid_list.rs covering range shrink, hysteresis retention, and new key acceptance - #14: Rewrite e2e test to send NeighborSyncRequest and assert response hints cover all locally stored keys - #15: Rewrite e2e test to store on 2 nodes, partition one, then verify paid-list authorization confirmable via verification request - #17: Rewrite e2e test to store data on receiver, send sync, and assert outbound replica hints returned (proving bidirectional exchange) - #55: Replace weak enum-distinctness check with full audit failure flow: compute digests, identify mismatches, filter by responsibility, verify empty confirmed failure set produces no evidence Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saorsa-coredependency from 0.20.0 to 0.21.0Test plan
cargo build --releasesucceeds locally🤖 Generated with Claude Code