Conversation
Add merge.yml for PR validation (build, clippy, fmt, tests, dry-run publish) and release.yml for publishing to crates.io via release-plz.
grumbach
force-pushed
the
ci/add-workflows
branch
from
8e5e576 to
91b3bc5
Compare
The test-utils feature was unused by any consumer. All cfg guards were already #[cfg(any(test, feature = "test-utils"))], so the test code compiled during cargo test anyway. Simplify by: - Removing the test-utils feature entirely - Moving dirs-next and serde_json to [dev-dependencies] - Replacing cfg guards with plain #[cfg(test)]
The contract selects a winner pool using block.prevrandao. With 4 pools, resubmitting the same data on a different block may select a different winner, which is valid (each pool hash can only be paid once, but different pools are independent). The test now correctly handles both outcomes: PaymentAlreadyExists if same winner, or success with a different winner verified against the original.
This is a library crate — git tags and crates.io publishing are sufficient; GitHub releases add no value. With releases disabled, the default GITHUB_TOKEN can push tags, removing the need for the EVMLIB_PAT secret entirely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Breaking changes were introduced in recent PRs (testnet functions now return Result types), so bump the minor version. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jacderida
force-pushed
the
ci/add-workflows
branch
from
e55ddbc to
1bd0536
Compare
jacderida
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge.ymlworkflow for PR validation: cross-platform build, clippy, rustfmt, tests, and dry-run publishrelease.ymlworkflow for publishing to crates.io viarelease-plz(manual trigger)release-plz.tomlconfig with tag formatv{{ version }}Bugfixes included
While getting CI green, fixed a few pre-existing issues:
serde_jsonanddirs-nextwere optional deps behind thetest-utilsfeature, but#[cfg(test)]code referenced them unconditionally. Moved both to[dev-dependencies]and removed the unusedtest-utilsfeature entirely (no consumer was using it).test_smart_contractwas failing: the duplicate payment test assumed the contract would always pick the same winner pool on a second call, butblock.prevrandaochanges between blocks so a different pool may be selected. Fixed the test to handle both outcomes correctly.lib/prb-mathsubmodule: a mode-160000 git entry with no.gitmodulesconfig was blockingcargogit fetches. Removed the orphaned reference.foundry-rs/foundry-toolchain@v1to the test job.Setup required
Two secrets need to be added to the repo settings (
Settings > Secrets and variables > Actions):CRATES_IO_TOKEN— API token from https://crates.io/settings/tokensEVMLIB_PAT— GitHub PAT with repo permissions (for creating tags/releases)