Open
Conversation
socket.c warnings for unused variables, and similar in wizchip_conf.c as well as some int/uint comparisons and one structure init that needed extra elements added.
Static functions cannot be accessed outside the file, so having their prototypes in a .h header file included by other code will cause compiler warnings. I commented out the prototypes in socket.h, and copied them into the socket.c.
There was a variable declared that was only used if building for 6100 or 6300 chips. Changed that to use the same #if that is used to include that code block, removing the warning. There was also a scanf() using %u for uint32_t variables. On systems where % is not 32-bits, this generates a compiler warning. Including inttypes.h gives access to PRIu32 which will be "whatever printf format represents uint32_t" on the compiler. If an old or lacking compiler is used without inttypes.h, the original line is still in there commented out. Maybe it needs a comment to explain this?
Prototypes without (void) can create compiler warnings. Ideally, the function should also have (void) instead of just () as some compilers will complain about that, but just fixing the ones that are showing up in MPLAB at the moment.
Author
|
// -Wall -Wextra -Wshadow -Wcast-qual -Wmissing-prototypes Not using -Wconversion yet since there are a ton of those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two minor compiler warnings -- one was from a variable that is only used on two chips. The fix was to just escape that declaration with the same #if that includes the code for that chip. The second was the use of %u in a scan for a uint32_t variable. On compilers that %u is not 32-bit, this is a warning. Instead, inttypes.h is used so you get PRIu32 which represents "whatever printf format represents uint32_t".