feat(perf): RAM-first indexing — batch SQLite write at end of scan (closes #10 phase-1)#111
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Implements issue #10: RAM-first indexing with batch SQLite write.
What changed
graph_nodes/graph_edgesin Python lists during scan (already in-memory from parsers; this PR makes the batch-write boundary explicit)executemany()for nodes + one for edges, wrapped in aBEGIN EXCLUSIVEtransaction (isolation_level=None+ explicitBEGIN EXCLUSIVE/COMMIT)populate_graph_tables(full scan) andincremental_graph_update(incremental scan) to collect all rows in memory BEFORE opening the EXCLUSIVE lock, minimizing lock-hold duration--scan-statsflag prints a two-line timing breakdown to stderr:--incrementalstill works — partial update path is preserved; the EXCLUSIVE-lock refactor applies to both full and incremental writesVerification
tests/test_scan_stats.pycovering the--scan-statsflag, the BEGIN EXCLUSIVE batch-write atomicity, and the incremental-scan interaction)codelens scanoutput unchanged (verified by subprocess test that asserts noScan stats:/Index time:lines on stderr without--scan-stats)--incrementalstill works: existingtests/test_graph_incremental.py(18 tests) all passscan.py,graph_model.py) and added on the new test filetests/test_hybrid_engine.py::TestHybridIntegration::test_query_confidence_without_deep— verified to fail onmain(commit 470e602) before this PRCloses #10