Skip to content

fix(dead-code): re-exports not counted as usage, causing false positives #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wolfvin merged 1 commit into from
Jul 11, 2026
Merged

fix(dead-code): re-exports not counted as usage, causing false positives #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion scripts/deadcode_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,10 +930,20 @@ def _collect_js_exports_imports(
# Re-exports: export { X } from ... vs local exports: export { X }
# export { X } without 'from' is a local definition being made public API.
# export { X } from './other' is a re-export from another module.
# export type { X } from './other' is a TypeScript type-only re-export.
# We distinguish these because local exports should not be flagged as unused
# (they are intentionally public API), while re-exports from other modules
# may be unnecessary if nothing imports them.
for m in re.finditer(r'export\s+\{([^}]+)\}(\s+from\s+[\'"\w./@-]+)?', content):
#
# Bug fix: a re-export ("export {X} from './y'" or "export type {X} from
# './y'") consumes X from the source module './y' — it IS a usage of X as
# far as the source file's own unused-exports check is concerned. Without
# recording these names in `imports`, any symbol that is only ever
# re-exported (never plain-imported) is incorrectly flagged as unused in
# its defining file (found via real-codebase validation: ProductAccess in
# google-auth-cache.ts, re-exported via `export type {...} from` in
# google-auth.ts, was a false positive).
for m in re.finditer(r'export\s+(?:type\s+)?\{([^}]+)\}(\s+from\s+[\'"\w./@-]+)?', content):
has_from = m.group(2) is not None
export_type = "re_export" if has_from else "local_export"
names = [n.strip().split(' as ')[0].strip() for n in m.group(1).split(',')]
Expand All @@ -944,6 +954,8 @@ def _collect_js_exports_imports(
"type": export_type,
"line": content[:m.start()].count('\n') + 1
})
if has_from:
imports[rel_path].add(name)

# Imports (including TypeScript type-only imports)
for m in re.finditer(r'import\s+(?:type\s+)?(?:\{([^}]+)\}|\*\s+as\s+(\w+)|(\w+))\s+from', content):
Expand Down
Loading