Skip to content

fix(circular): strip comments before import scan, fixes self-import false positive #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wolfvin merged 1 commit into from
Jul 11, 2026
Merged

fix(circular): strip comments before import scan, fixes self-import false positive #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scripts/circular_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,6 +785,17 @@ def _parse_js_imports(content: str, file_rel_path: str, workspace: str) -> List[
imports = []
file_dir = os.path.dirname(file_rel_path)

# Strip comments before scanning. Without this, an `import ... from '...'`
# example inside a `//` line comment or a docstring-style block comment
# gets matched as a real import, producing false self-import "cycles"
# (found via real-codebase validation: permission-gate.ts's own usage
# example comment — `// import { requirePermission } from
# '../middleware/permission-gate'` — was detected as the file importing
# itself).
from complexity_engine import _remove_comments
ext = os.path.splitext(file_rel_path)[1].lower()
content = _remove_comments(content, ext)

# ES module imports: import X from './path' or '../path'
for m in re.finditer(r'import\s+.*?from\s+["\'](\.{1,2}/[^"\']+)["\']', content):
raw = m.group(1)
Expand Down
Loading