Add New Mentors#562
Conversation
…first row as headers row by default
…versus default (ad-hoc) periods
| if current_period == "default" and mentorship_type == type_long_term[0]: | ||
| return 10 | ||
|
|
||
| return 500 |
There was a problem hiding this comment.
What is this default case? When is ad-hoc mentor and is available? Because for me the default should be 100, the sort above should be applied to long-term and ad-hoc. Bases in number of mentees and availability.
There was a problem hiding this comment.
As above, the "default" is now the usual period where we handle ad-hoc mentorship (May/June to December) and in this case, we want long-term only mentors to be at the bottom.
Overall, the updates I have made to the script is:
- keep the existing logic for long-term/both mentors during long-term registrations
- add new logic to properly sort mentors during the rest of the cycle (ad-hoc periods)
Following the guide: https://docs.google.com/document/d/1GwlleBNScHCQ3K8rgvYIB3upIr1BylgWjGR2jxwYWtI/edit?usp=sharing
| return 100 | ||
|
|
||
| return 10 | ||
| if current_period == "long-term": |
There was a problem hiding this comment.
I don't think this is necessary. The check is if is long term only and is not current period of long-term registration should be return as 10.
But if both or ad-hoc only should apply the sorting.
There was a problem hiding this comment.
I have made updates because we needed to make it easier to handle ad-hoc mentorship sorting that we currently have to do every month.
An extra parameter has been included to the script: "default" period is the regular period outside long term registrations where we handle ad-hoc mentorship.
so this part is to keep the existing logic for when long-term registration is happening.
Most of the details are included in the guide we use: https://docs.google.com/document/d/1GwlleBNScHCQ3K8rgvYIB3upIr1BylgWjGR2jxwYWtI/edit?usp=sharing
|
Branch to be separated out into two branches and PRs for quicker review |
2 participants
Description
long-termduring long-term registrations only,defaultfor the rest of the yearChange Type
Related Issue
Screenshots
Pull request checklist
Please check if your PR fulfills the following requirements: