Skip to content

fix: update footer link styles and text to match Figma #218 #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MitaliShah merged 2 commits into from
May 30, 2026
Merged

fix: update footer link styles and text to match Figma #218 #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2482e4
fix: update footer link styles and text to match Figma #218
MitaliShah Apr 19, 2026
6ffae11
fix: match footer UI and test locator to Figma specs #218
MitaliShah Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright-tests/pages/base.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export class BasePage {
Instagram: links.filter({ has: page.getByTestId('InstagramIcon') }),
Email: links.filter({ has: page.getByTestId('EmailIcon') }),
Slack: page.locator('a[href*="join.slack.com"]').last(),
'Send us a report': page.getByText('Send us a report', { exact: true }),
'Send us a report': page.getByText('Send us a report on GitHub', { exact: true }),
};
}

Expand Down
28 changes: 19 additions & 9 deletions src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,20 +130,30 @@ export const Footer = ({
</Box>
<Typography
variant="body1"
color="primary.dark"
typography={{ fontWeight: '600' }}
pt={2}
sx={{ fontSize: '16px' }}
sx={{
fontSize: '16px',
fontWeight: 500,
color: '#000000',
pt: 2,
}}
>
{link.title} <br />
{link?.title || 'Experiencing Technical Issues?'} <br />
<Link
href={link.uri}
color="primary.dark"
href={
link?.uri ||
'https://github.com/Women-Coding-Community/wcc-website/issues'
}
target="_blank"
rel="noopener noreferrer"
typography={{ fontWeight: '500' }}
sx={{
color: 'custom.linkBlue',
fontSize: '14px',
fontWeight: 400,
textDecoration: 'underline',
}}
>
{link.label}
{/* Hardcoded to match Figma #218 and override incomplete BE label */}
Send us a report on GitHub
</Link>
</Typography>
</Box>
Expand Down
Loading