fix: standardise breadcrumbs across mentorship pages (#201)#280
Open
IrynaLypnyk wants to merge 2 commits into
Open
fix: standardise breadcrumbs across mentorship pages (#201)#280IrynaLypnyk wants to merge 2 commits into
IrynaLypnyk wants to merge 2 commits into
Conversation
…mmunity#201) - unify usage of BreadCrumbsDynamic - remove inconsistent isMobile conditions - replace custom breadcrumbs with shared component - add consistent spacing to breadcrumbs - update tests to mock router pathname
dricazenck
approved these changes
May 3, 2026
dricazenck
reviewed
May 3, 2026
dricazenck
left a comment
dricazenck
left a comment
Collaborator
There was a problem hiding this comment.
Can you review the tests that are failing:
Validate Home Page › HP-004: Become Mentor section › Verify page contains text "Welcome to the MentorRegistrationPage"
|
Contributor
Author
|
@dricazenck Thanks for pointing this out! The failing test was expecting outdated text ("Welcome to the MentorRegistrationPage"), which no longer exists in the UI. I’ve updated it to match the current heading ("WCC: Registration Form for Mentors") and verified it locally. It looks like this test might have reverted to an older state after previous revert changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Breadcrumbs were inconsistent across pages (missing, conditionally rendered, or implemented differently).
issue #201
This PR:
BreadCrumbsDynamicisMobileconditionsType
Related Issue
Screenshots
BEFORE:
AFTER:
Testing
Note:
pnpm run test:e2e:dockercurrently fails with an existing HP-004 Become Mentor section failure. I reproduced the same failure onmain, so it appears unrelated to this PR.Pull request checklist
Please check if your PR fulfills the following requirements: