Make e2e link assertions robust to team ordering changes#296
Merged
ann-kilzer merged 2 commits intoupdate-leadership-teamfrom Mar 7, 2026
Merged
Make e2e link assertions robust to team ordering changes#296ann-kilzer merged 2 commits intoupdate-leadership-teamfrom
ann-kilzer merged 2 commits intoupdate-leadership-teamfrom
Conversation
Merged
Co-authored-by: ann-kilzer <4602369+ann-kilzer@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on leadership team update PR
Make e2e link assertions robust to team ordering changes
Feb 28, 2026
Collaborator
|
Since this is not branching into main, gonna merge without the review |
ann-kilzer
added a commit
that referenced
this pull request
Mar 7, 2026
This reverts commit d17ef0d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed 🧐
The e2e test link assertions relied on DOM order (
links[0],links[1]), making them brittle to team.json reordering or new URL additions.Before:
After:
Links are now scoped by filtering for elements containing the specific member's name.
How did you test it? 🧪
Verified the e2e test passes with the refactored assertions.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.