Merged
Conversation
mlebkowski
force-pushed
the
feature/messenger
branch
from
950e585 to
1591911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change takes the already working synchronous command bus (messenger) from testlocal.ly codebase and extends it with configurable async transports and the worker command.
The transports are not added, since wp and tl will use different ones. Instead a
TransportLocatorBuilderis provided to easily configure any named transports the codebase will require. A bunch of other dependencies are pre-configured in a way for them to be overriden if necessary.The handlers locators are lazy, which in theory should allow for them to depend on the command bus themselves, thus allowing handlers to re-dispatch commands and use queries.
Please consider Conventional Comments when commenting on PRs