Add save button to developer settings panel (Provider/Model selectors)#761
Add save button to developer settings panel (Provider/Model selectors)#761Infinite-Null wants to merge 3 commits into
Conversation
…tton in DeveloperSettings
…Settings component
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #761 +/- ##
==========================================
Coverage 76.41% 76.41%
Complexity 1828 1828
==========================================
Files 87 87
Lines 7764 7764
==========================================
Hits 5933 5933
Misses 1831 1831
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dkotter
left a comment
There was a problem hiding this comment.
Couple minor things but overall this looks good.
Ideally we get some E2E tests here though, to verify the new save button works and to also verify if you choose a provider/model and don't hit save, those values don't persist on page reload
| .ai-developer-mode-fields__actions { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: var(--wpds-dimension-gap-lg, 16px); |
There was a problem hiding this comment.
Looks like we're inconsistent with the fallback here, some places use 16px some use 12px. Should standardize that
What?
Closes #763
Adds an explicit Save button to the Developer Settings panel (Provider/Model selectors), instead of saving changes immediately on every selection.
Why
Provider and Model changes were being saved as soon as you picked a new option, with no confirmation step. This was inconsistent with the rest of the settings UI, where changes are only saved when you click Save. A moderator flagged this during review.
How to test
Before / After
Before: Selecting a new Provider or Model saved it instantly.
After: Selecting a new Provider or Model shows a Save button; the change is only saved when you click it.
Screenshots / Recording
Before
Screen.Recording.2026-06-23.at.5.26.45.PM.mov
After
Screen.Recording.2026-06-23.at.5.21.27.PM.mov
Changelog Entry