Skip to content

Add save button to developer settings panel (Provider/Model selectors)#761

Open
Infinite-Null wants to merge 3 commits into
WordPress:developfrom
Infinite-Null:add-save-button-to-developer-settings
Open

Add save button to developer settings panel (Provider/Model selectors)#761
Infinite-Null wants to merge 3 commits into
WordPress:developfrom
Infinite-Null:add-save-button-to-developer-settings

Conversation

@Infinite-Null

@Infinite-Null Infinite-Null commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What?

Closes #763

Adds an explicit Save button to the Developer Settings panel (Provider/Model selectors), instead of saving changes immediately on every selection.

Why

Provider and Model changes were being saved as soon as you picked a new option, with no confirmation step. This was inconsistent with the rest of the settings UI, where changes are only saved when you click Save. A moderator flagged this during review.

How to test

  1. Navigate to AI Settings and enable Enable AI.
  2. Open the Developer Tools menu (three dots) and select Model selection.
  3. Change the Provider or Model.
  4. Confirm a Save button appears and the change is not saved yet.
  5. Click Save and confirm the change persists.
  6. Confirm clicking on "Reset to default" shows a Save button, and Save still behaves as expected.

Before / After

Before: Selecting a new Provider or Model saved it instantly.
After: Selecting a new Provider or Model shows a Save button; the change is only saved when you click it.

Screenshots / Recording

Before

Screen.Recording.2026-06-23.at.5.26.45.PM.mov

After

Screen.Recording.2026-06-23.at.5.21.27.PM.mov

Changelog Entry

Added - New feature.
Changed - Existing functionality.
Deprecated - Soon-to-be removed feature.
Removed - Feature.
Fixed - Bug fix.
Security - Vulnerability.
Developer - Development related updates.

Open WordPress Playground Preview

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.41%. Comparing base (27e202b) to head (8e33f57).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #761   +/-   ##
==========================================
  Coverage      76.41%   76.41%           
  Complexity      1828     1828           
==========================================
  Files             87       87           
  Lines           7764     7764           
==========================================
  Hits            5933     5933           
  Misses          1831     1831           
Flag Coverage Δ
unit 76.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Infinite-Null Infinite-Null changed the title Add save button to developer settings Add save button to developer settings panel (Provider/Model selectors) Jun 23, 2026
@Infinite-Null Infinite-Null marked this pull request as ready for review June 23, 2026 12:02
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dkotter dkotter added this to the 1.1.0 milestone Jun 23, 2026

@dkotter dkotter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things but overall this looks good.

Ideally we get some E2E tests here though, to verify the new save button works and to also verify if you choose a provider/model and don't hit save, those values don't persist on page reload

Comment thread routes/ai-home/style.scss
.ai-developer-mode-fields__actions {
display: flex;
align-items: center;
gap: var(--wpds-dimension-gap-lg, 16px);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're inconsistent with the fallback here, some places use 16px some use 12px. Should standardize that

Comment thread routes/ai-home/components/DeveloperSettings.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Developer Settings: Model selections should require explicit Save (currently auto-save on change)

2 participants