E2E[Content Summarization]: Prefer user-facing attributes#762
Conversation
- Updated the test suite to use role-based selectors. - Refactored tests to verify button visibility and state more effectively, enhancing overall test reliability.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #762 +/- ##
==========================================
Coverage 76.41% 76.41%
Complexity 1828 1828
==========================================
Files 87 87
Lines 7764 7764
==========================================
Hits 5933 5933
Misses 1831 1831
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Also adds `exact: true` wherever required
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What, Why, and How?
Playwright recommends using user-facing locators (example,
getByRole) instead of CSS classes or DOM-structure selectors wherever possible. This is because CSS classes and markup structure are implementation details that can change during design or refactoring without changing the actual user experience, which can make tests fail even though the feature still works (Docs).This PR updates the content summarization E2E spec to follow the Playwright best practices by replacing hard-coded
page.locator(...)calls with role-based locators. This should make the test less brittle because it now targets the UI the way a user, or assistive technology, understands it rather than depending on implementation details.Apart from making the test more resilient to CSS and markup changes, this also makes the assertions easier to read and understand. For example:
Note: This PR deliberately scopes the change to the Content Summarization E2E spec only. If we agree this approach is preferable for the reasons above, we can apply it to other E2E specs incrementally, a few modules at a time.
Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.5
Used for: Code review
Testing Instructions
CI should be green.
Changelog Entry