Update dependencies and remove grunt tooling#117
Merged
Conversation
- Run npm audit fix to resolve transitive vulnerabilities (brace-expansion, path-to-regexp, serialize-javascript) - Remove grunt-checktextdomain and grunt-wp-i18n devDependencies and delete Gruntfile.js — PHPCS already covers text domain validation via WordPress.WP.I18n and I18nTextDomainFixer rules - Run npm update for semver-compatible bumps across all WordPress packages and other dependencies Reduces npm audit findings from 25 (18 high, 7 moderate) to 16 (10 high, 6 moderate). Remaining vulnerabilities are all in wordpress/scripts and wordpress/env transitive dependencies (dev-only tooling) with no non-breaking fix available upstream.
Resolve package-lock.json conflicts from concurrent dependency updates on trunk (axios, typescript).
Adds --testPathIgnorePatterns to the test:unit script so Jest skips any path containing /worktrees/. This prevents false failures from build-output tests in worktree copies that lack build artifacts, and avoids Haste module naming collisions from duplicate package.json files.
Runs npm audit fix to address 9 vulnerabilities in brace-expansion, follow-redirects, lodash, path-to-regexp, and transitive dependencies. Remaining 11 vulnerabilities require breaking changes to wp-scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm audit fixto resolve transitive vulnerabilities (brace-expansion, path-to-regexp, serialize-javascript)grunt-checktextdomainandgrunt-wp-i18ndevDependencies and deleteGruntfile.js— PHPCS already covers text domain validation viaWordPress.WP.I18nandI18nTextDomainFixerrulesnpm updatefor semver-compatible bumps across all WordPress packages and other dependenciesReduces npm audit findings from 25 (18 high, 7 moderate) to 16 (10 high, 6 moderate). Remaining vulnerabilities are all in
@wordpress/scriptsand@wordpress/envtransitive dependencies (dev-only tooling) with no non-breaking fix available upstream.Test plan
npm run lintpassesnpm run buildsucceedsnpm run test:unit— all 347 tests passnpm auditshows no new vulnerabilitiesvendor/bin/phpcsincludesWordPress.WP.I18nrule)