Plugin Check: Fix Missing $domain parameter #753
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
requested changes
Jan 27, 2026
| </button> | ||
|
|
||
| <em><?php esc_html_e( 'This invalidates all currently stored codes.' ); ?></em> | ||
| <em><?php esc_html_e( 'This invalidates all currently stored codes.', 'two-factor' ); ?></em> |
Collaborator
There was a problem hiding this comment.
Let's keep this one and remove the other changes since those are clones of WP core files due to bundling of required functions for the two-factor flow to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752
What?
Fix missing text domain arguments in translation function calls on the login header and footer, resolving WordPress Coding Standards (PHPCS) WordPress.WP.I18n.MissingArgDomain errors.
Why?
The affected files contained calls to __() and _x() without explicitly passing the text domain. While this may work at runtime, it violates WordPress i18n best practices and causes PHPCS errors in CI. Explicitly passing the two-factor text domain ensures correct translation loading and compliance with coding standards.
How?
Added the two-factor text domain to all affected internationalization function calls.
Updated the calls to include the required third $domain parameter.
No functional behavior was changed beyond improved translation correctness and standards compliance.
Testing Instructions
Changelog Entry
Fixed – Added missing text domain arguments to i18n function calls to comply with WordPress coding standards.