-
Notifications
You must be signed in to change notification settings - Fork 3.4k
I18N: Add translation support for script modules #11543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manzoorwanijk
wants to merge
24
commits into
WordPress:trunk
Choose a base branch
from
manzoorwanijk:add/script-module-translations
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+457
−14
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
e23d4f2
I18N: Add translation support for script modules.
manzoorwanijk 7057417
Tests: Add end-to-end coverage for script module translation printing.
manzoorwanijk 40bbbf2
Script Loader: Restore original position of print_enqueued_script_mod…
manzoorwanijk e23c08a
Docs: Update `@since` tags to 7.0.0 for script module translation APIs.
manzoorwanijk 1a0d9ca
Simplify by using null coalescing operator
manzoorwanijk 05c6016
Use ES6 and PHP 7.4 syntax
manzoorwanijk de8090f
Make PHPCS happy
manzoorwanijk 44a1f56
Revert the change to heredoc indentation
manzoorwanijk eb78a18
Tests: Align null return type for get_registered_src().
manzoorwanijk cee8f0c
Apply suggestions from code review
manzoorwanijk c3380cc
I18N: Extract shared helper for loading script translation files.
manzoorwanijk 2be0c57
Merge branch 'trunk' into add/script-module-translations
manzoorwanijk 28cfe1c
Use type-hints
manzoorwanijk 1354cb0
I18N: Reuse load_script_textdomain_relative_path filter for script mo…
manzoorwanijk 918490c
Merge branch 'trunk' into add/script-module-translations
manzoorwanijk 38dd31a
Rename get_registered_src() to get_registered()
westonruter 7aad84d
Use get_echo() in tests
westonruter a146cf8
Add covers for WP_Script_Modules::set_translations()
westonruter 555f309
Add assertions for new is_module arg for load_script_textdomain_relat…
westonruter d360841
Use HTML Tag Processor for inspecting output
westonruter db4106a
Fix variable name to use locale instead of local
westonruter da7e67a
Move load_script_module_textdomain() to immediately follow load_scrip…
westonruter 7d734d9
Add covers for load_script_module_textdomain()
westonruter 33b7f3b
Merge branch 'trunk' into add/script-module-translations
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use new function here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you mean to use a method call:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simpler yet:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see many other places where it use
if ( ! isset( $this->registered[ $id ] ) ) {, good to update that one also or we can do that in follow-up PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would lean towards updating all of those in a follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.