Skip to content

Tests: Fix flaky test_get_theme_featured_list_api skip instead of fail when WordPress.org API is unavailable #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sukhendu2002 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+33 −1
Draft

Tests: Fix flaky test_get_theme_featured_list_api skip instead of fail when WordPress.org API is unavailable #11556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion tests/phpunit/tests/admin/includesTheme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,40 @@ public function test_get_post_templates_child_theme() {
*/
public function test_get_theme_featured_list_api() {
wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );

/*
* Detect and suppress the wp_trigger_error() call that themes_api() fires on an
* HTTPS failure, which PHPUnit would otherwise convert to a test exception.
* Skip instead of fail when the API is unavailable.
*/
$api_error_message = null;

$detect_api_error = static function ( $function_name, $message ) use ( &$api_error_message ) {
if ( 'themes_api' === $function_name ) {
$api_error_message = $message;
}
};
add_action( 'wp_trigger_error_always_run', $detect_api_error, 10, 3 );

$suppress_api_error = static function ( $trigger, $function_name ) {
if ( 'themes_api' === $function_name ) {
return false;
}
return $trigger;
};
add_filter( 'wp_trigger_error_trigger_error', $suppress_api_error, 10, 2 );

$featured_list_api = get_theme_feature_list( true );

remove_action( 'wp_trigger_error_always_run', $detect_api_error );
remove_filter( 'wp_trigger_error_trigger_error', $suppress_api_error );

if ( null !== $api_error_message ) {
$this->markTestSkipped(
sprintf( 'WordPress.org Themes API is not available: %s', wp_strip_all_tags( $api_error_message ) )
);
}

$this->assertNonEmptyMultidimensionalArray( $featured_list_api );
}

Expand All @@ -241,7 +274,6 @@ public function test_get_theme_featured_list_api() {
*
* Differences in the structure can also trigger failure by causing PHP notices/warnings.
*
* @group external-http
* @ticket 28121
*/
public function test_get_theme_featured_list_hardcoded() {
Expand Down
Loading