Skip to content

Themes: Normalize Windows backslashes in theme directory paths.#11562

Draft
ArkaPrabhaChowdhury wants to merge 1 commit intoWordPress:trunkfrom
ArkaPrabhaChowdhury:fix/29051-theme-windows-paths
Draft

Themes: Normalize Windows backslashes in theme directory paths.#11562
ArkaPrabhaChowdhury wants to merge 1 commit intoWordPress:trunkfrom
ArkaPrabhaChowdhury:fix/29051-theme-windows-paths

Conversation

@ArkaPrabhaChowdhury
Copy link
Copy Markdown

Use wp_normalize_path() in register_theme_directory() and search_theme_directories() so that paths are always stored and compared with forward slashes. This prevents a White Screen when a database dump created on Windows is loaded on a Unix system, where the stored backslash paths no longer match WP_CONTENT_DIR.

Fixes #29051

Trac ticket: https://core.trac.wordpress.org/ticket/29051

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Use wp_normalize_path() in register_theme_directory() and
search_theme_directories() so that paths are always stored and
compared with forward slashes. This prevents a White Screen when a
database dump created on Windows is loaded on a Unix system, where
the stored backslash paths no longer match WP_CONTENT_DIR.

Fixes #29051
@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant