Implement a filter that removes all plain taxonomy class entries#102
Merged
vedran-kasalica merged 1 commit intomainfrom Jun 13, 2025
Merged
Conversation
… with suffix "_plain".
vedran-kasalica
approved these changes
Jun 13, 2025
Member
vedran-kasalica
left a comment
There was a problem hiding this comment.
This looks great, thanks! Indeed, it's best to rely on the _plain suffix. Alternatively, we REST APE could provide a pre-filtered taxonomy, of course.
Contributor
Author
|
Hi @vedran-kasalica, I agree that the best solution would be to already get filtered information from RESTful APE. Filtering in the frontend is obviously introducing superfluous runtime complexity. I added a feature request in RESTful APE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR will resolve #65.
Changes
Added a recursive function that creates a taxonomy class tree that does not contain the "_plain" id EDAM entries.
I did not filter by label
_psince this suffix is defined by restAPE. Instead, I used the EDAM URI suffixes which seems more stable to me.Testing
Tested it on the institutional instance at UP.
Checklist