Skip to content

Implement a filter that removes all plain taxonomy class entries#102

Merged
vedran-kasalica merged 1 commit intomainfrom
65-Remove-terms-with-_p-from-the-drop-down
Jun 13, 2025
Merged

Implement a filter that removes all plain taxonomy class entries#102
vedran-kasalica merged 1 commit intomainfrom
65-Remove-terms-with-_p-from-the-drop-down

Conversation

@eladrion
Copy link
Contributor

@eladrion eladrion commented Jun 13, 2025

Overview

This PR will resolve #65.

Changes

Added a recursive function that creates a taxonomy class tree that does not contain the "_plain" id EDAM entries.
I did not filter by label _p since this suffix is defined by restAPE. Instead, I used the EDAM URI suffixes which seems more stable to me.

Testing

Tested it on the institutional instance at UP.

Checklist

  • Code follows project standards.
  • Self-reviewed and commented where needed.
  • Documentation updated if needed.
  • No new warnings or errors.

Copy link
Member

@vedran-kasalica vedran-kasalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! Indeed, it's best to rely on the _plain suffix. Alternatively, we REST APE could provide a pre-filtered taxonomy, of course.

@vedran-kasalica vedran-kasalica merged commit 5b91bdb into main Jun 13, 2025
1 check passed
@vedran-kasalica vedran-kasalica deleted the 65-Remove-terms-with-_p-from-the-drop-down branch June 13, 2025 16:29
@eladrion
Copy link
Contributor Author

Hi @vedran-kasalica, I agree that the best solution would be to already get filtered information from RESTful APE. Filtering in the frontend is obviously introducing superfluous runtime complexity. I added a feature request in RESTful APE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove terms with "_p" from the drop-down

2 participants

Comments