Conversation
kretep
approved these changes
Jun 10, 2025
kretep
reviewed
Jun 10, 2025
| attributes: | ||
| label: Domain Config URL | ||
| description: Link to the domain's `config.json` file (must be publicly accessible) | ||
| placeholder: https://github.com/your-org/repo/blob/main/domains/your-domain/config.json |
Contributor
There was a problem hiding this comment.
@vedran-kasalica shouldn't this refer to the raw.githubusercontent.com version of the url?
Member
Author
There was a problem hiding this comment.
That should indeed be added to the database, I am not sure if we need to require the raw URL format but we could, maybe we can update taht
Contributor
There was a problem hiding this comment.
Ah, you mean it would be the database maintainer's task to rewrite the link? I guess that's fine as long as it's documented somewhere. Seems like a step that might be forgotten
Member
Author
There was a problem hiding this comment.
Indeed, it might be safer to update it in the form already, I'll make a PR with the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use yml template for a new domain request