Skip to content

WIP: [#3] Fix lab dates order and verify dates#4

Draft
shabiel wants to merge 1 commit intomasterfrom
lab-dates-3
Draft

WIP: [#3] Fix lab dates order and verify dates#4
shabiel wants to merge 1 commit intomasterfrom
lab-dates-3

Conversation

@shabiel
Copy link
Copy Markdown
Contributor

@shabiel shabiel commented Mar 17, 2025

Users reported that order date and verify dates don't match lab collection dates. This commit is an attempt to fix all the issues, but it's not a complete fix yet, as CPRS in RE+6^ORMLR discards the lab verify date and inserts its own hardcoded to NOW.

This code has not been tested yet. Do not merge!

Changes:

  • ISIIMP13: Hardcode order date to collection date, not NOW.
  • (new routine) ISIIMPL10: Copy of LRVER3A with Verify date hardcoded to collection date, not NOW. Called by ISIIMPL7.
  • ISIIMPL2: Set test date to be collection date
  • ISIIMPL7: Call new routine ISIIMPL10, instead of LRVER3A.
  • ISIIMPLT: New in progress unit test FLABDATE.

Users reported that order date and verify dates don't match lab
collection dates. This commit is an attempt to fix all the issues, but
it's not a complete fix yet, as CPRS in `RE+6^ORMLR` discards the lab
verify date and inserts its own hardcoded to NOW.

This code has not been tested yet. Do not merge!

Changes:

- ISIIMP13: Hardcode order date to collection date, not NOW.
- (new routine) ISIIMPL10: Copy of LRVER3A with Verify date hardcoded to collection
  date, not NOW. Called by ISIIMPL7.
- ISIIMPL2: Set test date to be collection date
- ISIIMPL7: Call new routine ISIIMPL10, instead of LRVER3A.
- ISIIMPLT: New in progress unit test FLABDATE.
@shabiel shabiel self-assigned this Mar 17, 2025
@shabiel shabiel marked this pull request as draft March 17, 2025 16:58
@shabiel
Copy link
Copy Markdown
Contributor Author

shabiel commented Mar 18, 2025

A quick note: my tests show that the code is by and large sound and produces good results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant