Pacing BLESS calls to work around BLE loss#484
Open
AfromD wants to merge 2 commits intoWouterJD:masterfrom
Open
Pacing BLESS calls to work around BLE loss#484AfromD wants to merge 2 commits intoWouterJD:masterfrom
AfromD wants to merge 2 commits intoWouterJD:masterfrom
Conversation
Owner
|
hi @AfromD; sorry for the long delay. But there were other prio's to be done at home :-) Thanks for the code-delay suggestions and I have implemented it in the code. The essential is that the delay is implemented in the main BLEserver class and that the bleBless uses it, to keep the delay code away from the funtional code. Curious to hear from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures that calls to BLESS functions have a minimal delay between them. It is a workaround to avoid BLE becoming unresponsive after a duration of time. It is suspected that calling BLESS too quickly causes it to become unrespoinsive. This code fixes this by ensuring a delay has expired before the next call.
This commit has been tested by me for multiple hours of actual cycling and seems to have cured the BLE losses.