Conversation
Member
rbnswartz
commented
Jun 24, 2025
rbnswartz
commented
- Fix the handling of * end markers
- Fixed the trailing text after end markers
- Make sure newlines end marker and start content
- Handle other charecters ending the marker
- Permissively support ending a marker at number
- Mark symbol end test as permissive also
- Handle ideographic space rentention at the start of verses
PurpleGuitar
approved these changes
Jun 25, 2025
Collaborator
PurpleGuitar
left a comment
PurpleGuitar
left a comment
There was a problem hiding this comment.
Looks good. I appreciate your well-documented tests that go along with the code!
Member
Author
|
The reason I needed this in the first place was that I didn't have sufficient unit test coverage... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.