add local make wasm target again#388
Open
irmen wants to merge 3 commits into
Open
Conversation
Fulgen301
requested changes
May 31, 2026
Comment on lines
+29
to
+33
| EMSCRIPTEN_TOOLCHAIN ?= $(shell \ | ||
| emcc=$$(command -v emcc 2>/dev/null) && \ | ||
| dir=$$(dirname $$(readlink -f "$$emcc")) && \ | ||
| echo "$$dir/cmake/Modules/Platform/Emscripten.cmake") | ||
|
|
Collaborator
There was a problem hiding this comment.
If Emscripten isn't installed or can't be found, this will be empty, causing it to build normally for the host platform and failing later when the wasm artifacts can't be found. This should error early so that an accidental make wasm without emscripten doesn't seem to build correctly at first.
also add a better way to find the rom.bin required for wasm build also add build-wasm directory to cleanup targets for make clean and distclean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a make wasm target again so you can build the wasm web emulator locally again.
Requires emscripten to be installed as usual.
Fixes #375
disclaimer: most of the change was created by an AI agent because I don't know cmake very well.
note the ci builds fail not because of this particular PR but because there is a problem in the github action related to the pdf docs, this is fixed in #389