Refactored ATG CLI, combined info() and set() into execute() function.#1
Open
eredden wants to merge 1 commit intoX3N0V3RS3:mainfrom
Open
Refactored ATG CLI, combined info() and set() into execute() function.#1eredden wants to merge 1 commit intoX3N0V3RS3:mainfrom
eredden wants to merge 1 commit intoX3N0V3RS3:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have modified the code for this program in these ways:
Keeping
info()andset()as separate functions does not make much sense sinceinfo()could already run any command including the commands ran inset(). All you would need to do in order to replicate theset()function's purpose would be to runexecute()(formerly info) twice on each ATG system, once with a set function message code (likes601000) and again with a display function message code (likeI20100).Let me know if you have any questions or concerns.