Open
Conversation
Extract shared UTXO fetch/verify and input signing data logic into prepareInputs.ts, removing ~120 duplicated lines from multisigOutputs.ts. Also remove dead paymentScript() function and its unused imports.
droplister
changed the title
- Add Fund Multisig page for creating bare multisig (P2MS) funding transactions - Add Sign Transaction page for signing raw transactions - Add Combine Sigs page for assembling multisig scriptSigs from DER signatures - Add Broadcast Transaction page with mempool.space link - Add Multisig section to Actions menu (Fund → Sign → Combine → Broadcast) - Add multisig address validation and compose adjustments for legacy sends - Disable memos and MPMA for multisig destinations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepareInputs.ts, eliminating ~120 duplicated lines betweentransactionSigner.tsandmultisigOutputs.tspaymentScript()function and its unused imports (p2pkh,p2sh,p2tr)multisigOutputs.ts("fallback" → "bare multisig output scripts detected")Test plan
npx tsc --noEmitpassesnpx vitest run src/utils/blockchain/bitcoin/__tests__/transactionSigner.test.ts— 32 passed, 1 skippednpx vitest run src/utils/blockchain/bitcoin/__tests__/bareMultisig.test.ts— 13 passed