Skip to content

Fixed block-breaking-particle duplication, fast-falling rain, and FOV transition bugs. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Geforce132 wants to merge 1 commit into from
Closed

Fixed block-breaking-particle duplication, fast-falling rain, and FOV transition bugs. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/xcompwiz/lookingglass/client/proxyworld/ProxyWorldManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ public static WorldView createWorldView(int dimid, ChunkCoordinates spawn, int w
EntityLivingBase backup = mc.renderViewEntity;
mc.renderViewEntity = view.camera;
view.getRenderGlobal().setWorldAndLoadRenderers(proxyworld);
// The line of code below prevents block-breaking particles from duplicating
// when a WorldView exists in the same dimension as the player. I've haven't
// noticed any unwanted results from using this yet.
if(proxyworld.provider.dimensionId == Minecraft.getMinecraft().thePlayer.dimension) proxyworld.removeWorldAccess(view.getRenderGlobal());
mc.renderViewEntity = backup;

// Inform the server of the new view
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/xcompwiz/lookingglass/client/render/RenderUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public final static void renderWorldToTexture(float renderTime, int framebuffer,
EXTFramebufferObject.glBindFramebufferEXT(EXTFramebufferObject.GL_FRAMEBUFFER_EXT, framebuffer);
GL11.glClearColor(1.0f, 0.0f, 0.0f, 0.5f);
GL11.glClear(GL11.GL_COLOR_BUFFER_BIT);

entityRenderer.updateRenderer();
//entityRenderer.updateRenderer();

int i1 = mc.gameSettings.limitFramerate;
if (mc.isFramerateLimitBelowMax()) {
Expand Down
7 changes: 5 additions & 2 deletions src/main/java/com/xcompwiz/lookingglass/render/WorldViewRenderManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ public static void onRenderTick(PrintStream printstream) {
activeview.camera.inventory.mainInventory[playerBackup.inventory.currentItem] = currentClientItem; //Prevents the hand from flickering

try {
mc.entityRenderer.updateRenderer();
// TODO: A "fast-falling rain" bug occurs when the two updateRenderer() calls in WorldViewRenderManager
// and one in RenderUtils aren't commented out. There doesn't seem to be any issues with not
// calling them (everything still looks to render properly), so this is a quick fix for the time being.
//mc.entityRenderer.updateRenderer();
mc.renderGlobal.updateClouds();
mc.theWorld.doVoidFogParticles(MathHelper.floor_double(activeview.camera.posX), MathHelper.floor_double(activeview.camera.posY), MathHelper.floor_double(activeview.camera.posZ));
mc.effectRenderer.updateEffects();
Expand All @@ -78,7 +81,7 @@ public static void onRenderTick(PrintStream printstream) {
mc.renderGlobal = renderBackup;
mc.theWorld = worldBackup;
RenderManager.instance.set(mc.theWorld);
mc.entityRenderer.updateRenderer();
//mc.entityRenderer.updateRenderer();
}

}