Fix #1004 - #1005
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a scoped CSS rule to adjust the height of the Monaco merge editor inside the compare element so the diff viewer fits within the fixed-height container. Flow diagram for injecting Monaco merge host height styleflowchart TD
A[Render CompareElement div with fixed height] --> B[Create compareElementStyle using document.createElement]
B --> C["Set textContent to #CompareElement .monaco-merge-host { height: 95%; }"]
C --> D[Append compareElementStyle to document.head]
D --> E[Monaco merge editor height constrained within CompareElement]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Fix #1004
How does this PR accomplish the above?:
Add height style for
#CompareElement .monaco-merge-hostin L4973-L4975By submitting this pull request, I confirm the following:
git rebase)Summary by Sourcery
Enhancements:
Summary by cubic
Sets a fixed height for the Monaco merge editor in the compare view to prevent clipping and empty space, fixing #1004. Injects a style that sets
#CompareElement .monaco-merge-host { height: 95%; }.Written for commit ef0ecbb. Summary will update on new commits.