Skip to content

Fix #1004 - #1006

Merged
boomzero merged 42 commits into
devfrom
extern-contrib
Aug 6, 2026
Merged

Fix #1004#1006
boomzero merged 42 commits into
devfrom
extern-contrib

Conversation

@boomzero

@boomzero boomzero commented Aug 6, 2026

Copy link
Copy Markdown
Member

Merge back.

Summary by Sourcery

Bug Fixes:

  • Fix the CompareElement merge editor area being too short by enforcing a taller height via an injected style rule.

Summary by cubic

Fixes the Compare view merge editor height so the diff fits the container and no longer overflows (fixes #1004).
Injects #CompareElement .monaco-merge-host { height: 95%; }, and bumps version to 3.6.1 in XMOJ.user.js and package.json with an Update.json entry.

Written for commit e0d35f1. Summary will update on new commits.

Review in cubic

boomzero and others added 30 commits May 3, 2025 19:23
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@hendragon-bot hendragon-bot Bot added the user-script This issue or pull request is related to the main user script label Aug 6, 2026
@sourcery-ai

sourcery-ai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the styling of the compare view’s Monaco merge editor so it occupies 95% of the CompareElement container height, likely to resolve layout or visibility issues referenced in issue #1004.

File-Level Changes

Change Details Files
Ensure the Monaco merge editor inside the compare view uses most of the vertical space in the CompareElement container.
  • Create a <style> element at runtime in main() to customize the compare view styling.
  • Set a CSS rule targeting '#CompareElement .monaco-merge-host' to use 95% height.
  • Append the dynamically created style element to document.head so the rule takes effect.
XMOJ.user.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@boomzero

boomzero commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

We should try cherry-picking next time.

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Aug 6, 2026
@hendragon-bot hendragon-bot Bot added size/XS and removed size/S labels Aug 6, 2026
@boomzero
boomzero merged commit 5cd9fd5 into dev Aug 6, 2026
7 of 8 checks passed
@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Aug 6, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The inline creation of a global <style> tag for #CompareElement .monaco-merge-host on each main() run can lead to repeated style injection; consider guarding so the style is only added once or scoping/removing it when the compare view is torn down.
  • Hard-coding height: 95% on .monaco-merge-host may be brittle across layout changes; it might be more robust to tie the height to the parent container (e.g., using flex/grid layout or height: 100% with appropriate parent sizing) instead of a magic percentage.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The inline creation of a global `<style>` tag for `#CompareElement .monaco-merge-host` on each `main()` run can lead to repeated style injection; consider guarding so the style is only added once or scoping/removing it when the compare view is torn down.
- Hard-coding `height: 95%` on `.monaco-merge-host` may be brittle across layout changes; it might be more robust to tie the height to the parent container (e.g., using flex/grid layout or `height: 100%` with appropriate parent sizing) instead of a magic percentage.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S user-script This issue or pull request is related to the main user script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants