Fix #1004 - #1006
Merged
Merged
Conversation
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
sync: dev to extern-contrib
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the styling of the compare view’s Monaco merge editor so it occupies 95% of the CompareElement container height, likely to resolve layout or visibility issues referenced in issue #1004. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Member
Author
|
We should try cherry-picking next time. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The inline creation of a global
<style>tag for#CompareElement .monaco-merge-hoston eachmain()run can lead to repeated style injection; consider guarding so the style is only added once or scoping/removing it when the compare view is torn down. - Hard-coding
height: 95%on.monaco-merge-hostmay be brittle across layout changes; it might be more robust to tie the height to the parent container (e.g., using flex/grid layout orheight: 100%with appropriate parent sizing) instead of a magic percentage.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline creation of a global `<style>` tag for `#CompareElement .monaco-merge-host` on each `main()` run can lead to repeated style injection; consider guarding so the style is only added once or scoping/removing it when the compare view is torn down.
- Hard-coding `height: 95%` on `.monaco-merge-host` may be brittle across layout changes; it might be more robust to tie the height to the parent container (e.g., using flex/grid layout or `height: 100%` with appropriate parent sizing) instead of a magic percentage.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge back.
Summary by Sourcery
Bug Fixes:
Summary by cubic
Fixes the Compare view merge editor height so the diff fits the container and no longer overflows (fixes #1004).
Injects
#CompareElement .monaco-merge-host { height: 95%; }, and bumps version to 3.6.1 inXMOJ.user.jsandpackage.jsonwith anUpdate.jsonentry.Written for commit e0d35f1. Summary will update on new commits.