-
Notifications
You must be signed in to change notification settings - Fork 34
feat: align the SDK + spec with the live API contract (verified against production) #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
muunkky
wants to merge
5
commits into
XTraceAI:main
Choose a base branch
from
muunkky:cr/live-verified-reconciliation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ba00aec
docs: add architecture decision records and design docs
muunkky 2aac62e
feat(http): live error envelope, rate-limit headers, opt-in x-api-key…
muunkky 98bd604
feat(sdk): filter DSL, recall include, searchAll, superseded resolver…
muunkky 802baa1
fix(spec): correct error envelope, rate-limit headers, and PATCH to l…
muunkky 03565d7
docs(readme): document the reconciled surface (auth, rate limits, pat…
muunkky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented types-sync script missing
Low Severity
The README states
npm run check:types-syncexists and is chained intoprepublishOnly, andsrc/types.tstells maintainers to keep the generated reference in sync via that command.package.jsondefines neither acheck:types-syncscript nor that step inprepublishOnly(onlytypecheck,test, andbuild), so the documented guard cannot run and publish is not protected as described.Additional Locations (1)
src/types.ts#L1-L5Reviewed by Cursor Bugbot for commit 03565d7. Configure here.