fix: consistently handle loading states across primitives#72
Conversation
🦋 Changeset detectedLatest commit: c7b89f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 91.29% 91.40% +0.10%
==========================================
Files 20 20
Lines 724 733 +9
Branches 138 140 +2
==========================================
+ Hits 661 670 +9
Misses 55 55
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request aims to consistently handle loading states across primitives in solid-relay by updating createLazyLoadQueryInternal to use a switch statement handling 'ok', 'error', and 'loading' states. However, the reviewer identified that setting the initial and fallback pending states to false when data and error are both undefined violates the DataStore<T> type contract, which could lead to runtime crashes. The reviewer provided suggestions to keep pending as true in these scenarios to preserve type safety.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
solid-relay | c7b89f7 | Commit Preview URL Branch Preview URL |
May 27 2026, 06:29 AM |
Closes #71