fix: mark all subagents as non-interactive for permission asks#1537
Open
Ivaloz wants to merge 1 commit into
Open
fix: mark all subagents as non-interactive for permission asks#1537Ivaloz wants to merge 1 commit into
Ivaloz wants to merge 1 commit into
Conversation
All subagents (whether 'run' sync or 'spawn' background) are non-interactive: they have no attached human to reply to permission prompts, so an ask that would block must fail clean with DeniedError instead of hanging. Previously, only SYSTEM_SPAWNED_AGENT_TYPES and background actors were marked non-interactive. This caused sync subagents (run operation) to hang indefinitely when they triggered a permission ask, because they were treated as interactive actors waiting for user confirmation. Fixes XiaomiMiMo#1455-style hang for subagent permission prompts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All subagents (whether 'run' sync or 'spawn' background) are non-interactive: they have no attached human to reply to permission prompts, so an ask that would block must fail clean with DeniedError instead of hanging.
Previously, only SYSTEM_SPAWNED_AGENT_TYPES and background actors were marked non-interactive. This caused sync subagents (run operation) to hang indefinitely when they triggered a permission ask, because they were treated as interactive actors waiting for user confirmation.
This fixes the issue where subagents would hang forever waiting for permission confirmation that never comes.