fix(tui): stop left/right arrow propagation in permission and questio…#1548
Open
Gaobo-Hp1 wants to merge 1 commit into
Open
fix(tui): stop left/right arrow propagation in permission and questio…#1548Gaobo-Hp1 wants to merge 1 commit into
Gaobo-Hp1 wants to merge 1 commit into
Conversation
…n prompts - Add evt.stopPropagation() to left/right key handlers in PermissionPrompt - Add evt.stopPropagation() to left/right key handlers in QuestionPrompt - Prevents arrow key events from propagating to CommandProvider which would trigger unintended subAgent navigation via session_child_cycle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #1547 1547
Type of change
What does this PR do?
When a permission prompt or question prompt is shown, pressing left/right arrow keys to switch options triggers subAgent navigation instead, because CommandProvider's global useKeyboard handler matches session_child_cycle/session_child_cycle_reverse (bound to bare left/right) before the prompt's own handler runs.
These prompts are rendered inline inside the session component, not via the Dialog system, so CommandProvider's dialog.stack.length > 0 guard doesn't skip them.
Fix: add evt.stopPropagation() in both prompts' left/right key handlers to prevent the event from reaching CommandProvider.
How did you verify your code works?
Checklist
Maybe upgrade the opencode version can fix this problem, opencode use keymapping.