Skip to content

Remove warning for inexact result in PDLL binary arithmetic operation #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ge28boj merged 1 commit into from
Jun 11, 2025
Merged

Remove warning for inexact result in PDLL binary arithmetic operation #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions mlir/lib/Dialect/PDL/IR/Builtins.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,15 +274,11 @@ LogicalResult static binaryOp(PatternRewriter &rewriter, PDLResultList &results,
"encounter an unsupported binary operator.");
}

if (operationStatus != APFloat::opOK) {
if (operationStatus != APFloat::opInexact)
return failure();

emitWarning(rewriter.getUnknownLoc())
<< "Binary arithmetic operation between " << lhsVal.convertToFloat()
<< " and " << rhsVal.convertToFloat()
<< " produced an inexact result";
if (operationStatus != APFloat::opOK &&
operationStatus != APFloat::opInexact) {
return failure();
}

results.push_back(rewriter.getFloatAttr(floatType, resultVal));
return success();
}
Expand Down