Skip to content

wip: constant folding for concat #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorickert wants to merge 1 commit into from
Closed

wip: constant folding for concat #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2097,6 +2097,44 @@ struct ReduceConstantOptimization : public OpRewritePattern<OperationType> {
const bool aggressiveReduceConstant;
};

struct TosaFoldConstantConcat : TosaFoldConstantBase<tosa::ConcatOp> {
using TosaFoldConstantBase::TosaFoldConstantBase;

LogicalResult matchAndRewrite(tosa::ConcatOp op,
PatternRewriter &rewriter) const override {
auto inputsRange = op.getInput1();
auto axis = op.getAxis();

// TODO: Matching constraints

// collect all inputvalues
SmallVector<DenseElementsAttr> inputValuesArr;
SmallVector<ShapedType> inputTypesArr;
for (auto input : inputsRange) {
DenseElementsAttr inputValues;
if (!matchPattern(input, m_Constant(&inputValues))) {
return failure();
}
inputValuesArr.push_back(inputValues);
inputTypesArr.push_back(cast<ShapedType>(input.getType()));
}

// compute result
auto result = this->concat(inputValuesArr, inputTypesArr, axis);

rewriter.replaceOpWithNewOp<tosa::ConstOp>(op, result.first, result.second);
}

std::pair<ShapedType, DenseElementsAttr>
concat(SmallVector<DenseElementsAttr> &inputValuesArr,
SmallVector<ShapedType> &inputTypesArr, uint32_t axis) const {
auto baseType = inputTypesArr[0].getElementType();
switch (dyn_cast<IntegerType>(baseType).getWidth()) {
// TODO:
}
}
}

} // namespace

void mlir::tosa::populateTosaFoldConstantPatterns(
Expand Down Expand Up @@ -2136,6 +2174,7 @@ void mlir::tosa::populateTosaFoldConstantPatterns(
patterns.add<TosaFoldConstantPad>(ctx, options.foldSplatOrSingleUseOnly);
patterns.add<TosaFoldConstantSlice>(ctx, options.foldSplatOrSingleUseOnly);
patterns.add<TosaFoldConstantMatMul>(ctx, options.foldSplatOrSingleUseOnly);
patterns.add<TosaFoldConstantConcat>(ctx, options.foldSplatOrSingleUseOnly);
if (options.enableTileFolding)
patterns.add<TosaFoldConstantTile>(ctx, options.foldSplatOrSingleUseOnly);
}
Expand Down
Loading