Use typed TArrayUtilities.Fill overloads for byte/word fills#136
Merged
Conversation
Add a Fill(TCryptoLibInt32Array) overload beside the existing Byte / UInt32 / UInt64 ones, then switch every TArrayUtilities.Fill<T> call in the library (160 sites: 121 Byte, 16 UInt32, 19 UInt64, 4 Int32) to the matching non-generic overload. These map to FillChar / FillDWord / FillQWord (memset) instead of the generic per-element loop and are correct for any filler value, including negative Int32. Also replace the six FillChar calls that wipe dynamic byte arrays with TArrayUtilities.Fill; the remaining FillChar uses (pointer derefs and fixed arrays/records, which Fill can't take) are left as-is. The generic Fill<T> stays as the fallback for other element types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Fill(TCryptoLibInt32Array) overload beside the existing Byte / UInt32 / UInt64 ones, then switch every TArrayUtilities.Fill call in the library to the matching non-generic overload. These map to FillChar / FillDWord / FillQWord (memset) instead of the generic per-element loop and are correct for any filler value, including negative Int32.
Also replace the six FillChar calls that wipe dynamic byte arrays with TArrayUtilities.Fill; the remaining FillChar uses (pointer derefs and fixed arrays/records, which Fill can't take) are left as-is. The generic Fill stays as the fallback for other element types.