Harden ASN.1 stream materialization, add id-kp-imUri, and lower PBE iteration ceiling#137
Merged
Merged
Conversation
Add TKeyPurposeId.IdKpImUri (1.3.6.1.5.5.7.3.40), TLimitedInputStream leave-open support with PipeAllLimited updated accordingly, and incremental DefiniteLength ToArray via TLimitedCapacityMemoryStream. On FPC, CopyTo/ReadAll/ReadFully dispatch through Read(var), so move bulk read logic onto Read(var) for DefiniteLength, IndefiniteLength, ConstructedOctet, and ConstructedBit streams (TArray delegates down). This ensures large BER/DER payloads materialize through efficient bulk reads instead of byte-at-a-time fallback paths.
…ests. Lower default PBE iteration ceiling to 5_000_000 and add regression tests. Expose CheckPbeIterationCount so callers can validate PBKDF2 iteration counts before key derivation, and add PKCS#8/PBES2 tests for the new limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TKeyPurposeId.IdKpImUri(1.3.6.1.5.5.7.3.40) for RFC 5280 key purpose identification.TLimitedInputStreamleave-open support and updatePipeAllLimitedaccordingly.TLimitedCapacityMemoryStreaminstead of allocating the full declared length up front.CopyTo/ReadAll/ReadFullydispatch throughRead(var), so move bulk-read logic ontoRead(var)for definite-length, indefinite-length, constructed octet, and constructed bit streams (TArraydelegates down). This avoids byte-at-a-time fallback paths when materializing large BER/DER payloads.10_000_000to5_000_000, exposeCheckPbeIterationCountfor early validation, and add PKCS#8/PBES2 regression tests for the new limit.