Prefix shared SIMD include scaffolding with Clp to avoid HashLib collisions#139
Merged
Conversation
…isions
The SIMD prologue/save-restore scaffolding (Include\Simd\Common) and the
CPUID/XGETBV probes (Include\Simd\CpuFeatures) are copied into both this
library and HashLib4Pascal and have since diverged (they branch on
CRYPTOLIB_* vs HASHLIB_* defines). Because both packages expose these
identically-named .inc files on their include search path, Lazarus emits
"Duplicate file" warnings, and FPC's include resolution could in principle
bind CryptoLib to HashLib's copy (wrong ABI prologue).
Rename the 16 shared files with a Clp prefix so no basename is shared
between the two libraries, updating the {$I} references and the comment
mentions of them. The CpuIdQuery/XGetBvQuery procedures keep their names;
only the include files are renamed. Paths stay .pas-relative, so the
existing -Fi depth anchor still resolves and Delphi is unaffected.
docs: add mobile TestInsight test harness guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SIMD prologue/save-restore scaffolding (Include\Simd\Common) and the CPUID/XGETBV probes (Include\Simd\CpuFeatures) are copied into both this library and HashLib4Pascal and have since diverged (they branch on CRYPTOLIB_* vs HASHLIB_* defines). Because both packages expose these identically-named .inc files on their include search path, Lazarus emits "Duplicate file" warnings, and FPC's include resolution could in principle bind CryptoLib to HashLib's copy (wrong ABI prologue).
Rename the 16 shared files with a Clp prefix so no basename is shared between the two libraries, updating the {$I} references and the comment mentions of them. The CpuIdQuery/XGetBvQuery procedures keep their names; only the include files are renamed. Paths stay .pas-relative, so the existing -Fi depth anchor still resolves and Delphi is unaffected.