fix(settings): accept palette in the preferences PATCH allowlist - #1621
Merged
Conversation
The Appearance pane saves theme and palette together (the palette picker's 'claude' never string-matches the stored "" default, so the pane's diff always includes palette). preferencesPatch was missing the field, so the strict decoder 400'd every appearance save with 'invalid or unknown preference fields' — even a plain theme change. userPreferences/validatePreferences (settings_domain.go) already carry the palette field and its allowlist; only the typed PATCH body and its apply() were out of sync. Regression test covers both the happy path and that an invalid palette now hits per-field validation instead of the unknown-field guard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Appearance-tab save error "Preferences could not be saved — invalid or unknown preference fields".
preferencesPatch(dashboard/settings_api.go) — the strictly-decoded PATCH body — was missing thepalettefield, whileuserPreferences/validatePreferences(settings_domain.go) already define it. The Appearance pane's save always includespalettein the diff (the picker's"claude"never string-matches the stored""default), so the strict decoder rejected every appearance save — even a plain theme change.Change: add
Palette *stringtopreferencesPatch+ copy inapply(); regression test for the round-trip and for invalid values hitting per-field validation instead of the unknown-field guard.go teston the dashboard package: green.🤖 Generated with Claude Code