Skip to content

hotfixed device error in interpolation#84

Closed
J-Hizzle wants to merge 2 commits intoXzzX:mainfrom
J-Hizzle:main
Closed

hotfixed device error in interpolation#84
J-Hizzle wants to merge 2 commits intoXzzX:mainfrom
J-Hizzle:main

Conversation

@J-Hizzle
Copy link
Copy Markdown
Contributor

@J-Hizzle J-Hizzle commented Mar 3, 2026

When I tried to compile on a GPU system, there was an error in interpolation.cpp due to the host trying to access information stored in device memory. I fixed it and now MRMD is GPU safe again.

@XzzX
Copy link
Copy Markdown
Owner

XzzX commented Mar 4, 2026

Hmm, unfortunate, actually running ctest in the CI and not just compiling would have found this. But GitHub does not have GPU runners available in their free plan...

@XzzX
Copy link
Copy Markdown
Owner

XzzX commented Mar 4, 2026

The change is pretty expensive. You are copying to host only to get some boundaries. Does the output have to be a histogram? If a ScalarView is enough you can avoid all the copying.

@J-Hizzle
Copy link
Copy Markdown
Contributor Author

J-Hizzle commented Mar 4, 2026

The change is pretty expensive. You are copying to host only to get some boundaries. Does the output have to be a histogram? If a ScalarView is enough you can avoid all the copying.

Oh, wait. The changes are obsolete: The input does not have to be a grid! See ref. #73, where I changed the interpolation routine already.

@XzzX
Copy link
Copy Markdown
Owner

XzzX commented Mar 17, 2026

So we can close this?

@J-Hizzle
Copy link
Copy Markdown
Contributor Author

So we can close this?

Yes.

@XzzX XzzX closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants