[Feat] 토닥이 채팅 domain layer 구성 - #82
Open
oungsi2000 wants to merge 7 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ChatStreamException을 제거하고 ChatStreamEvent의 하위 타입으로 Error를 추가한다. 스트림 처리 중 발생하는 에러를 별도 예외(Exception) 대신 이벤트의 일부로 포함하여 명시적으로 관리한다.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
`SendChatMessageUseCaseTest`의 `runTest` 블록 들여쓰기와 줄바꿈을 일관되게 수정하고, `ChatStreamEvent`에 trailing comma를 추가하여 스타일 가이드를 준수한다. `FakeChatRepository`에서 단순 failure를 반환하는 메서드들을 단일 행으로 정리하여 가독성을 높인다.
oungsi2000
marked this pull request as draft
August 4, 2026 18:10
oungsi2000
marked this pull request as ready for review
August 4, 2026 18:13
Error 데이터 클래스가 ChatStreamEvent를 상속하도록 수정하여 채팅 스트림 이벤트 처리 시 타입 일관성을 유지하고 에러 상태를 정상적으로 포함할 수 있도록 한다.
카테고리 정보가 없는 채팅 엔트리를 지원하기 위해 `category` 타입을 String?로 변경한다.
기존 String 타입이었던 category를 ChatCategory Enum으로 변경하여 타입 안정성을 확보한다. 카테고리는 RELATIONSHIP, LOVE, ACHIEVEMENT, MONEY, HEALTH의 5가지 항목으로 정의한다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
#72
#73
작업 내용
변경사항 / 상세
중점 리뷰사항
스크린샷 (선택)