[Feat] 토닥이 채팅 SSE 클라이언트 설정 및 DTO 구성 - #83
Draft
oungsi2000 wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bodyAsChannel로 event/data/id/retry 필드를 직접 파싱하던 코드를 Ktor 3.1.3에 번들된 sse() + ClientSSESession.incoming: Flow<ServerSentEvent>로 교체. 와이어 포맷 파싱(멀티라인 data, 주석 줄 등)을 직접 구현/유지보수하지 않고 Ktor 자체 구현에 맡긴다. SseFlowTest.kt는 삭제한다: sse()는 요청에 SSECapability를 태그하고 HttpClientEngine.checkExtensions가 엔진의 지원 여부를 검사하는데, MockEngine(3.1.3)은 이 capability를 선언하지 않고 final class라 확장도 불가능해 연결 단계에서 시나리오와 무관하게 무조건 IllegalArgumentException을 던진다(실측 확인). 이벤트 매핑 커버리지는 ChatMapperTest가 ServerSentEvent를 직접 구성해 이미 담당하고 있고, 스트리밍 자체는 dev 서버 스모크 테스트로 검증한다. 검증: core:data-remote 컴파일/테스트/ktlintCheck 전부 통과.
SseFlow.kt를 ServerSentEvents.kt로 이름을 변경하여 명확성을 높인다. ChatStreamErrorResponse의 code와 message 필드를 Non-nullable로 변경하여 에러 응답 시 필수 정보가 누락되지 않도록 제약을 강화한다.
oungsi2000
changed the base branch from
feat/59-todak-chat
to
feat/73-chat-usecase
August 6, 2026 15:56
oungsi2000
force-pushed
the
feat/75-chat-dto
branch
from
August 6, 2026 15:56
2ee2590 to
b12b4f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
#74
#75
작업 내용
변경사항 / 상세
중점 리뷰사항
스크린샷 (선택)