chore: AWS S3 공개 버킷 추가 - #126
Conversation
|
Warning Review limit reached
Next review available in: 44 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough공개 정적 자산용 S3 버킷과 접근 정책을 추가했습니다. Terraform이 버킷 이름을 출력합니다. Makefile이 파일 또는 디렉터리를 업로드합니다. 인프라 문서가 키 prefix와 URL을 설명합니다. EC2 루트 볼륨은 30GB gp3로 설정했습니다. Changes공개 정적 자산
EC2 루트 볼륨
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant Makefile
participant Terraform
participant S3Bucket
Developer->>Makefile: upload-asset 또는 upload-assets 실행
Makefile->>Terraform: public_bucket_name 조회
Terraform-->>Makefile: S3 버킷 이름 반환
Makefile->>S3Bucket: 파일 업로드 또는 prefix 동기화
S3Bucket-->>Makefile: 업로드 완료
Makefile-->>Developer: CDN 및 원본 URL 출력
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Line 126: Update the uploads around the Makefile commands at Makefile lines
126-126 and 134-134 to remove the one-year cache lifetime for mutable
channels/<channel-id>.png and users/<user-id>.png keys, applying the same
short-TTL cache policy used for single-file uploads at both sites.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f955a2c4-d3f5-41bd-a5c7-c5576b5885cf
📒 Files selected for processing (8)
Makefiledocs/infra.mdinfra/environments/aws/prod/main.tfinfra/environments/aws/prod/team-access.tfinfra/modules/aws/app/main.tfinfra/modules/aws/app/outputs.tfinfra/modules/aws/app/s3-public.tfsrc/test/resources/application.yaml
💤 Files with no reviewable changes (1)
- src/test/resources/application.yaml
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
코드 리뷰 결과 (자동)이 PR은 인프라(Terraform) 변경 중심으로, 공개 정적 자산용 S3 버킷 추가 및 관련 IAM/Makefile/문서 변경입니다. must-fix 관점에서 검토한 결과는 아래와 같습니다. 🟠 Major
🟡 Minor
나머지 변경(퍼블릭 버킷 정책의 |
* chore: AWS S3 공개 버킷 추가 (#126) * feat(infra): add public S3 bucket and upload commands for static assets * docs: document public static assets S3 bucket * chore: remove unused region field from onboarding S3 test config * chore(infra): increase EC2 root volume to 30GB and switch to gp3 * fix: address review feedback on public assets bucket * fix(infra): scope down public bucket permissions and fix access log delivery * feat: 저장된 시뮬레이션 목록 및 상세 조회 API 구현 (#130) * fix(simulation): mark optional response fields NOT_REQUIRED instead of nullable * feat(simulation): add saved simulation detail API * feat(simulation): add paginated my-simulations list API * chore(simulation): drop unused SimulationNotFoundException import * fix(simulation): omit null fields from simulation item responses * fix(simulation): count only funded channels in list summaries * docs(simulation): add a page/size example to the list API 400 response * feat: 채널 추천 결과 저장 API 구현 (#133) * fix(security): scope the public recommendations path to GET * fix(openapi): publish data and error as required on response wrappers * feat(recommendation): add channel recommendation save API * fix(recommendation): serialize saves per onboarding * feat: add flyway migration v16 * feat(channel): filter the channel list by primary category (#134) * feat: 온보딩 나이대 응답에 "잘 모르겠어요"(UNDECIDED) 추가 (#138) * feat(infra): disable aws scheduler * refactor(performance): build AdPerformance via Lombok builder instead of positional constructor * feat(onboarding): let users answer "don't know" for target age band * refactor(onboarding): extract OnboardingNotFoundException for id-based lookups * test(onboarding): cover UNDECIDED-alone and AdPerformance ratio branches --------- Co-authored-by: Yelim Lee <142207312+1117mg@users.noreply.github.com>
2 participants
🔗 관련 이슈
Closes #125
📝 작업 내용
✅ 체크리스트
💬 리뷰 참고 사항
Cloudflare Cloud Connector로 서빙 도메인(assets.chaeso-zip.com)을 연결했습니다.
로컬환경에서 S3 파일 업로드시 MAKEFILE 을 참고하여 업로드 가능합니다.
관련 기능이 없는 관계로 앱 인스턴스에는 S3 버킷 쓰기 권한을 주지 않았습니다.
서버 인스턴스 30GB도 같이 명시했습니다
Summary by CodeRabbit
새 기능
문서
개선