feat: 채널 목록 조회에 업종 필터 추가 - #134
Open
1117mg wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthrough채널 목록 조회 API에 Changes채널 대표 업종 필터
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant ChannelController
participant ChannelService
participant ChannelRepositoryImpl
participant ChannelQuery
Client->>ChannelController: primaryCategory 입력
ChannelController->>ChannelService: getChannels(name, primaryCategories, pageable)
ChannelService->>ChannelRepositoryImpl: searchActiveChannels(name, primaryCategories, pageable)
ChannelRepositoryImpl->>ChannelQuery: 활성 상태와 카테고리 조건으로 조회
ChannelQuery-->>ChannelRepositoryImpl: 채널 결과와 전체 개수
ChannelRepositoryImpl-->>ChannelService: 페이지 결과 반환
ChannelService-->>ChannelController: 채널 페이지 반환
ChannelController-->>Client: 채널 목록 응답
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #134 +/- ##
============================================
- Coverage 88.44% 88.14% -0.31%
Complexity 469 469
============================================
Files 105 105
Lines 1437 1442 +5
Branches 111 111
============================================
Hits 1271 1271
- Misses 122 127 +5
Partials 44 44
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/chaeso/zip/server/channel/presentation/ChannelApiDocs.java`:
- Around line 126-127: Update the API description near the primaryCategory
filter in ChannelApiDocs to explicitly state that primaryCategory and name are
combined with an AND condition, so both filters must match when provided
together. Use valid Category examples such as SHOPPING_COMMERCE and GAME instead
of A and B.
In `@src/test/java/chaeso/zip/server/channel/domain/ChannelRepositoryTest.java`:
- Around line 87-92: Replace the assumeTrue guard in the multi-category test
with a failing assertion that requires categories.size() to equal 2, so
insufficient fixture data fails the test instead of skipping it; keep the
existing activeChannels category collection unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 77f38bb0-7e60-466d-acaf-e0209e69f3da
📒 Files selected for processing (9)
src/main/java/chaeso/zip/server/channel/application/ChannelService.javasrc/main/java/chaeso/zip/server/channel/application/ChannelServiceImpl.javasrc/main/java/chaeso/zip/server/channel/domain/repository/ChannelRepositoryCustom.javasrc/main/java/chaeso/zip/server/channel/domain/repository/ChannelRepositoryImpl.javasrc/main/java/chaeso/zip/server/channel/presentation/ChannelApiDocs.javasrc/main/java/chaeso/zip/server/channel/presentation/ChannelController.javasrc/main/java/chaeso/zip/server/channel/presentation/dto/ChannelSearchRequest.javasrc/test/java/chaeso/zip/server/channel/domain/ChannelRepositoryTest.javasrc/test/java/chaeso/zip/server/channel/presentation/ChannelControllerTest.java
🔎 PR 리뷰 결과머지를 막을 만한 문제를 찾지 못했습니다. 확인한 항목
머지해도 좋습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
Closes #131
📝 작업 내용
primaryCategory필터 추가 (다중 선택 지원)name과 함께 보내면 두 조건 모두 만족하는 채널만 응답✅ 체크리스트
Summary by CodeRabbit
새로운 기능
문서