이새연/3주차#4
Open
owhat02 wants to merge 1 commit into
Open
Conversation
프로그래머스 개인정보 수집유효기간
YEOUL0520
reviewed
Sep 25, 2024
|
|
||
| //����� ���ᳯ¥�� �������Ƥþƾ���� �� | ||
| for (int i = 0; i < index_pri; i++) { | ||
| if (stoi(date_y[i]) < stoi(today_year) || |
Owner
There was a problem hiding this comment.
이부분 가독성이 너무 떨어지는것같아요
해당 안되는 경우를 빼주는 쪽이 더 간단할 것 같음!
YEOUL0520
reviewed
Sep 25, 2024
| if (date_m[j].size() == 1) { date_m[j] = "0" + date_m[j]; } | ||
| } | ||
| //���� �Ⱓ ���� ��� | ||
| int ydata = (stoi(terms_month[i])) / 12; |
Owner
There was a problem hiding this comment.
달의 경우 12달이 넘어갔을 때 나누기를 해주는 것은 좋았는데 연도 넘어가는걸 고려하지 않은 것 같아요!!
sseoh47
reviewed
Oct 2, 2024
sseoh47
left a comment
sseoh47
left a comment
There was a problem hiding this comment.
저 역시 한글 주석이 깨져 보여서 조금 신경쓰여요.
파일 인코딩 설정 때문인듯!! 추후 올릴때 config파일의 인코딩 설정을 utf-8로 바꾸면 될 것 같아요~.
sseoh47
reviewed
Oct 10, 2024
| //���� �Ⱓ �� ��� | ||
| int mdata = (stoi(terms_month[i])) % 12; | ||
| if ((stoi(date_m[j]) + mdata) > 12) { //���� 12�� �Ѿ ��� | ||
| int date = stoi(date_m[j]); |
There was a problem hiding this comment.
문자열에서 정수형으로 형변환 후 문자열으로 바꿨다가 정수형태로 다시 계산하는 것이 있는 것 같아요. 계산이 계속 이어진다면 정수형태로 계속 한다면 코드가 좀 더 간단해질 것 같아요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
프로그래머스 개인정보 수집유효기간