This repository was archived by the owner on May 26, 2020. It is now read-only.
Open
Conversation
Collaborator
|
I like having a sample both locally and with the CDN. The CDN examples work
as standalones and don't require setting up and environment, building, etc.
Also when we publish live demos they'll always use the CDN. I'm out of the
office until the end of June, happy to continue ur the conversation then.
…On Jun 14, 2017 7:47 PM, "Marc Gagne" ***@***.***> wrote:
Resolves Issue #40 <#40>
- Moves samples into ./samples//.html
- Removes samples that refer to published .js (uses local .js and .css
only) for AzSearch.js and AzSearch.css
- Resolves HTML lint issues with missing closing tags () and scripts
outside of
------------------------------
You can view, comment on, or merge this pull request online at:
#44
Commit Summary
- Introducing samples & updating references to use @latest syntax for
css/js CDN.
- Removing root samples and updating README
- Moved into samples folder, fixed HTML errors
File Changes
- *M* README.md
<https://github.com/EvanBoyle/AzSearch.js/pull/44/files#diff-0> (4)
- *D* realestate.html
<https://github.com/EvanBoyle/AzSearch.js/pull/44/files#diff-1> (293)
- *D* realestate.local.html
<https://github.com/EvanBoyle/AzSearch.js/pull/44/files#diff-2> (301)
- *A* samples/realestate/realestate.html
<https://github.com/EvanBoyle/AzSearch.js/pull/44/files#diff-3> (302)
- *A* samples/realestate/realestate.no-filters.html
<https://github.com/EvanBoyle/AzSearch.js/pull/44/files#diff-4> (214)
Patch Links:
- https://github.com/EvanBoyle/AzSearch.js/pull/44.patch
- https://github.com/EvanBoyle/AzSearch.js/pull/44.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#44>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACb1U_mg2ldaMuPe4glnQ-a8VV1dy75Zks5sEBzJgaJpZM4N6OMz>
.
|
Collaborator
|
Yeah what do you think about versioning the samples. I think it's a benefit that we refer to a specfiic verison in the samples. It makes it easy to download the sample and run it yourself. Otherwise someone has to build the entire project. Having the realestate.html and the realestate.local.html nicely avoids this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Issue #40